Commits

Chris Lattner committed 35bce55e623
When diagnosing some problems with associated types, mark the decl invalid. When forming a type reference to an invalid type decl, have validateType return ErrorType instead of an apparently valid type. This silences some bogus downstream errors in code that references the decl. This exposes some wierdness with while_parsing_as_left_angle_bracket where one case the note is being is when resolveType returns a failure. However, resolveType can produce a failure without emitting a diagnostic, and this can lead to us generating a note unattached to an error. Just remove this case.