swift234

pass a decl into diagnostic generation directly, instead of passing in the
decl loc, this simplifies code and can theoretically handle deserialized
decls better.  Noticed by inspection, NFC.