swift234

[SILOpt] Use getEffectiveAccess instead of getFormalAccess.

Since this code has an isAvailableExternally check, this probably makes
no difference, but it's still more correct: SIL-level code should
always use a declaration's effective access.