swift234

Some belated code review for the constant prop pass.  Overall
the algorithm looks great, I made a number of minor stylistic
and comment changes, used some simpler APIs, and simplified
some things.  The only functionality change is a corner case
correctness bug where it looks like the struct/tuple extraction
folding logic in constantFoldInstruction could return the wrong
result in some corner case.


Swift SVN r9547