swift234

Sema: Use isTypeChecking() to avoid recursively validating EnumElementDecls

Validating the argument type might validate the enum decl in malformed (or
maybe even some valid?) code. We would call computeTwice() in this case,
leading to a crash.

Also clean up some test cases.

Swift SVN r30673