swift234

[TypeChecker] Refactor the accessibility calculations for declarations into a separate TypeChecker::validateAccessibility() function.

This is so that AccessFilteringDeclConsumer can filter without validating decls, thus avoiding unnecessary typechecking for
private declarations across the module during code-completion.

Test case on the SourceKit side.

Swift SVN r22052