swift234

When this code was ported over from LLDB to swift, ConstString was redefined from being lldb_private::ConstString to being std::string

lldb's ConstString comes with a guarantee of keeping the underlying const char* storage alive for the lifetime of the process, so storing pointers from a ConstString as raw const char* is a safe operation
std::string does not come with equal guarantees, so storing such pointers as a raw const char* is actually an unsafe operation

Transform the storage into a std::string since that is safer to do