swift234

Sema: Fix @discardableResult for Self-returning methods on classes and protocols

When we form calls to these methods, the ApplyExpr is wrapped in an
additional conversion. Dig through these to produce the right diagnostic
(or not, if the method is @discardableResult).

Fixes <https://bugs.swift.org/browse/SR-1890>.