swift234

Update SideEffectAnalysis to use BasicCalleeAnalysis.

This is one step towards removing the full call graph. In the process it
removes a bit of brittleness around side effect analysis queries which
previously may or may not have returned the most conservative result
depending on whether we already had a valid call graph constructed.